Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish/unpublish to active #304

Merged
merged 14 commits into from
Jun 14, 2024
Merged

Conversation

andersonjeccel
Copy link
Contributor

Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Some Vale fixes to address here, I've suggested fixes for most of them but feel free to discuss if the suggestions don't work. Also some instances of unactive -> inactive which I've fixed with proposed changes.

docs/campaigns/creating_campaigns.rst Outdated Show resolved Hide resolved
docs/channels/focus_items.rst Outdated Show resolved Hide resolved
docs/channels/focus_items.rst Outdated Show resolved Hide resolved
docs/configuration/settings.rst Outdated Show resolved Hide resolved
docs/points/points.rst Outdated Show resolved Hide resolved
docs/stages/stages.rst Outdated Show resolved Hide resolved
docs/users_roles/managing_roles.rst Outdated Show resolved Hide resolved
docs/users_roles/managing_roles.rst Outdated Show resolved Hide resolved
@andersonjeccel
Copy link
Contributor Author

Do you know if this one still needs to be merged?
#251

Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of fixes left!

docs/channels/focus_items.rst Outdated Show resolved Hide resolved
docs/configuration/settings.rst Outdated Show resolved Hide resolved
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG thanks @andersonjeccel - something I thought is maybe we can add Publish / Unpublish to Vale's warnings and suggest the corrections based on the new terminology, perhaps.

@RCheesley RCheesley merged commit be14703 into mautic:5.x Jun 14, 2024
2 checks passed
@andersonjeccel
Copy link
Contributor Author

@RCheesley Makes sense, but I searched about it with no success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants